search

phonegap / phonegap-app-stockpile

n. - A storage pile accumulated for future use
Apache License 2.0
4 stars 10 forks source link

npm run build not reading uncommited config.js on local repo #16

Open hermwong opened 6 years ago

hermwong commented 6 years ago

Discovered this issue when I was trying to set up the deployment of the Stockpile on Firebase.

I had modified src/utils/config.js file on my local repo with my Adobe Stock API key.

I did not commit the changes in src/utils/config.js because I did not want to my Adobe Stock API key to be stored in the repository.

When I used npm run build to create the production build of the App for deployment on Firebase, it did not use my uncommitted version of src/utils/config.js, the build script used the last committed version of src/utils/config.js which contains a placeholder value for the Adobe Stock API key.

To get around this issue, I had to create a local branch and commit my modified src/utils/config.js before running npm run build to get the production build of the App to use my Adobe Stock API key.

devgeeks commented 6 years ago

I think it's more related to git commands than npm run build.

I can change the file then run a build and it keeps my API key, but if I do a commit or something similar the key reverts to the *****'s