phonegap / phonegap-plugin-contentsync

Download and cache remotely hosted content
Apache License 2.0
206 stars 98 forks source link

Files with unicode characters cause corrupt unzipping #192

Open zivkashtan opened 6 years ago

zivkashtan commented 6 years ago

Expected Behaviour

Files and directories need to be unzipped in the same way they were packed.

Actual Behaviour

Some files and directories are completely missing from the unzipped version.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Zip a directory with a file or files with unicode characters, for me it was נonus_players-sheet0.png (notice the נ I accidentally dropped in)

Fetch the file and unzip using: ContentSync.sync({src: "https://s3.....", id:"Content/Games", type:"merge" });

Upon completion, files will be unzipped in the correct directory but with missing content. (In my case it was a whole directory that was missing and some js files)

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

Android 6.0, Android 7.0

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

Checked on three different phones (LG, Oneplus and Samsung Galaxy), same behavior.

Cordova CLI version and cordova platform version

cordova 8.0,0
android 6.2.3

Plugin version

cordova-plugin-android-permissions 1.0.0 "Permissions" cordova-plugin-app-event 1.2.1 "Application Events" cordova-plugin-compat 1.2.0 "Compat" cordova-plugin-crosswalk-webview 2.3.0 "Crosswalk WebView Engine" cordova-plugin-file 4.3.3 "File" cordova-plugin-globalization 1.0.9 "Globalization" cordova-plugin-splashscreen 4.1.0 "Splashscreen" cordova-plugin-statusbar 2.4.1 "StatusBar" cordova-plugin-whitelist 1.3.3 "Whitelist" phonegap-plugin-contentsync 1.4.2 "content-sync"

Sample Code that illustrates the problem

No sample code available since I don't get any errors.

Logs taken while reproducing problem

No logs available since I'm not getting any output on this problem.