search

phonegap / phonegap-plugin-contentsync

Download and cache remotely hosted content
Apache License 2.0
206 stars 98 forks source link

`id` param containing a '/' returns error code 4 on iOS #57

Closed blefebvre closed 9 years ago

blefebvre commented 9 years ago

To reproduce, clone https://github.com/blefebvre/phonegap-contentsync-plugin-issue and run cordova platform add ios && cordova run ios.

Result: screen shot 2015-08-11 at 5 01 48 pm

The sync works fine if '/' is removed from the id: https://github.com/blefebvre/phonegap-contentsync-plugin-issue/blob/master/www/js/index.js#L38

Works as expected on Android.

mwbrooks commented 9 years ago

I can't think of any major side-effects to Simon's commit. @imhotep should also review it though.

Also, thanks @macdonst for cleaning up the whitespace.

macdonst commented 9 years ago

Merged

blefebvre commented 9 years ago

Is it possible that error code 4 could happen again? If so, can we add an entry to the ERROR_STATE enumeration?

imhotep commented 9 years ago

doubtful