search

phonegap / phonegap-plugin-contentsync

Download and cache remotely hosted content
Apache License 2.0
206 stars 98 forks source link

Change id in plugin.xml #7

Closed macdonst closed 9 years ago

macdonst commented 9 years ago

Hey,

Can we change the plugin ID from "com.adobe.phonegap.content-sync" to "com.adobe.phonegap.contentsync" as package names can't have hyphens in Java?

mwbrooks commented 9 years ago

Yup that's fair! Let's just ensure that the iOS and WP code bases work after the ID change!

On Thursday, March 5, 2015, Simon MacDonald notifications@github.com wrote:

Hey,

Can we change the plugin ID from "com.adobe.phonegap.content-sync" to "com.adobe.phonegap.contentsync" as package names can't have hyphens in Java?

— Reply to this email directly or view it on GitHub https://github.com/phonegap/phonegap-plugin-contentsync/issues/7.

macdonst commented 9 years ago

@mwbrooks Yeah, that's what I'm waiting on. Had some emergency stuff to take care of for Marketing Summit for the AEM guys and didn't get a chance to talk to @imhotep and @timkim.

purplecabbage commented 9 years ago

Class and variable names should not be dependent on plugin id. You can call the Java class whatever you want, as long as it matches what's in plugin.xml If this was a restriction then cordova-plugin-device would be broken, along with half the core cordova plugins. If you are renaming this, it should probably have an id of phonegap-plugin-contentsync to fit in the npm world.

macdonst commented 9 years ago

@purplecabbage good call, I made that the ID when I fixed this issue. Submitting to NPM later today.