search

phonegap / phonegap-plugin-media-recorder

Apache License 2.0
14 stars 20 forks source link

Video recording always records audio #3

Closed macdonst closed 7 years ago

macdonst commented 7 years ago

Right now it doesn't matter if you pass true or false in to record audio if there is a video stream it will always record video.

The root cause of the problem is this line https://github.com/phonegap/phonegap-plugin-media-recorder/blob/master/src/iOS/CDVMediaRecorder.m#L39

cameraViewController.isAudio = command.arguments[2];

As it will always evaluate to true. It should be something like this:

cameraViewController.isAudio = [[command argumentAtIndex:2 withDefault:@(NO)] boolValue];

After that is fixed please verify that audio is not recorded if you don't want it.

macdonst commented 7 years ago

@maverickmishra confirmed fixed