phonegap / phonegap-plugin-push

Register and receive push notifications
MIT License
1.94k stars 1.91k forks source link

Android notification icon #2167

Open xyboox opened 6 years ago

xyboox commented 6 years ago

Expected Behaviour

Icon should be placed in /platforms/android/res directory ( as per docs ), but there is no such directory anymore in my Ionic 3 project, I guess since Cordova v8 ( please see the screenshot ) screenshot at jan 26 10-42-28

Actual Behaviour

-

Reproduce Scenario (including but not limited to)

start an empty project and add android platform

Steps to Reproduce

-

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

all android

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

-

Cordova CLI version and cordova platform version

cli packages: (/usr/local/lib/node_modules)

@ionic/cli-utils  : 1.19.1
ionic (Ionic CLI) : 3.19.1

global packages:

cordova (Cordova CLI) : 8.0.0 

local packages:

@ionic/app-scripts : 3.1.6
Cordova Platforms  : android 7.0.0 ios 4.5.4
Ionic Framework    : ionic-angular 3.9.2

System:

Android SDK Tools : 26.1.1
ios-deploy        : 1.9.2 
Node              : v8.9.4
npm               : 5.6.0 
OS                : macOS High Sierra
Xcode             : Xcode 9.2 Build version 9C40b 

Plugin version

cordova plugin version | grep phonegap-plugin-push   # e.g. 1.5.3

Sample Push Data Payload

not relevant

Sample Code that illustrates the problem

not relevant

Logs taken while reproducing problem

not relevant

Thank you!

macdonst commented 6 years ago

@xyboox yeah the new folder is platforms/android/app/src/main/res, I'll look into updating the docs.

xyboox commented 6 years ago

Thanks @macdonst !

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.