phonegap / phonegap-plugin-push

Register and receive push notifications
MIT License
1.94k stars 1.91k forks source link

Update FirebaseMessaging #2486

Open maxs15 opened 6 years ago

maxs15 commented 6 years ago

Expected Behaviour

Use of FirebaseMessaging 3.0

Actual Behaviour

Use of FirebaseMessaging 2.0

Sample Code that illustrates the problem

<framework src="FirebaseMessaging" type="podspec" spec="~> 2.0.0"/>

Are you considering updating FirebaseMessaging to ~> 3.0.0 ? It's an issue when using other plugins (such as cordova-plugin-firebase-analytics) using Firebase/Core 5.0, there is a conflict FirebaseMessaging 3.0 is required to use FirebaseCore 5.0. I updated the dependency on my side, the only change I had to do is to replace:

@import FirebaseInstanceID;
@import FirebaseMessaging;
@import FirebaseAnalytics;

to

@import Firebase;

Maybe a change we could merge in the 3.0 release ?

Thanks @macdonst

jcesarmobile commented 6 years ago

Maybe make it configurable as on Android? not sure if the preferences work on the iOS framework tags.

maxs15 commented 6 years ago

I don't think that's possible, especially if we have to change the source code. Updating firebase could help fixing a few bugs as well, better be up to date in my opinion.

macdonst commented 6 years ago

@maxs15 good idea, we should do that for the next release.

AndreasGassmann commented 6 years ago

Is there currently a way to get the push-plugin to work together with let's say https://github.com/chemerisuk/cordova-plugin-firebase-dynamiclinks (which uses FirebaseCore 5.0), or do we have to wait for this issue to be resolved?

ikishanoza commented 5 years ago

any news on this ? @macdonst

jorgehclinhares commented 4 years ago

I'm getting the same error, any news?

eddOrnelas commented 4 years ago

I just made it work just need some more tests for push features on ios devices, but i can tell you you can install an old version of cordova-plugin-firebase-dynamiclinks@1.2.1 in combination of this PR there will no be errors when creating de xcode project using cordova platform add ios all the pod will install flawless i already tested the dynamic links on IOS, just need more test for push on IOS

regards