phonegap / phonegap-plugin-push

Register and receive push notifications
MIT License
1.94k stars 1.91k forks source link

Bump Dependency cordova-support-google-services@~1.3.1 #2817

Closed erisu closed 5 years ago

erisu commented 5 years ago

Description

Updated the cordova-support-google-services dependency listed in plugin.xml to use version ~1.3.1.

Related Issue

fixes: https://github.com/phonegap/phonegap-plugin-push/issues/2779

There are other various issue tickets that can be related. For example:

fixes: https://github.com/phonegap/phonegap-plugin-push/issues/2796

Motivation and Context

To be able to use newer versions of Google related services.

How Has This Been Tested?

$ npm i -g cordova
/Users/dev/n/bin/cordova -> /Users/dev/n/lib/node_modules/cordova/bin/cordova
+ cordova@9.0.0

$ cordova create googleservices com.dev.googleservices googleservices && $_
Creating a new cordova project.

$ cordova platform add android
Using cordova-fetch for cordova-android@^8.0.0
Adding android project...
Creating Cordova project for the Android platform:
    Path: platforms/android
    Package: com.dev.googleservices
    Name: googleservices
    Activity: MainActivity
    Android target: android-28
Subproject Path: CordovaLib
Subproject Path: app
Android project created with cordova-android@8.1.0
Plugin 'cordova-plugin-whitelist' found in config.xml... Migrating it to package.json
Discovered saved plugin "cordova-plugin-whitelist". Adding it to the project
Installing "cordova-plugin-whitelist" for android
Adding cordova-plugin-whitelist to package.json

$ cordova plugin add github:erisu/phonegap-plugin-push\#update-cordova-support-google-services-1.3.x
Installing "phonegap-plugin-push" for android
Installing "cordova-support-google-services" for android
Subproject Path: CordovaLib
Subproject Path: app
Installing "phonegap-plugin-multidex" for android
Subproject Path: CordovaLib
Subproject Path: app
Subproject Path: CordovaLib
Subproject Path: app
Adding phonegap-plugin-push to package.json

cp /tmp/google-services.json ./

Added to the <platform name="android"> doc block in config.xml

<resource-file src="google-services.json" target="app/google-services.json" />
$ cordova build android
...
BUILD SUCCESSFUL in 5s
46 actionable tasks: 46 executed
Built the following apk(s):
    /../googleservices/platforms/android/app/build/outputs/apk/debug/app-debug.apk

$ adb install /../googleservices/platforms/android/app/build/outputs/apk/debug/app-debug.apk
...
Success

I launched the application and Device is Ready is displaying.

Screenshots (if appropriate):

Types of changes

Checklist:

lock[bot] commented 4 years ago

This thread has been automatically locked.