search

phonegap / phonegap-template-react-hot-loader

PhoneGap Template using React, ES2015, Webpack, and hot module reloading
MIT License
79 stars 21 forks source link

CB-11412 Update templates to designate template source dir #5

Closed carynbear closed 8 years ago

devgeeks commented 8 years ago

I assume these are in prep for the changes to templates and should not be pulled in yet?

stevengill commented 8 years ago

Probably needs a quick review but it should work with existing cordova as well next one with the changes

devgeeks commented 8 years ago

OK. I'll review it today then!

mwbrooks commented 8 years ago

I left a few comments on phonegap/phonegap-template-framework7#6 that are related to this one.

mwbrooks commented 8 years ago

Heads up, I noticed that this was merged. Will it not break the current releases of the PhoneGap / Cordova CLIs? Merging it prevents us from doing any patches until the next Cordova update.

stevengill commented 8 years ago

existing cordova-cli template work should work with this updated template.

devgeeks commented 8 years ago

I tested it with:

~ Brodie 💀  cordova --version
6.2.0
~ Brodie 💀  phonegap --version
6.2.6

And it worked fine. It's not published to npm quite yet though just in case something comes up with the Desktop app review of hello-world

stevengill commented 8 years ago

Yeah, i tested it with cordova 6.2.0 and with the new PR [1] by @carynbear enhancing template support. Works with both.

With the new PR [1], package.json name and version field will also be updated.

@devgeeks if you want, you can modify the default values in the package.json inside template_src. So the name, version, author, etc can all be dumb default values. Something similar to [2]. Of course, you will probably want to leave in the scripts object and dependencies.

[1] https://github.com/apache/cordova-lib/pull/456 [2] https://github.com/phonegap/phonegap-template-blank/blob/master/template_src/package.json