phonegap / phonegap-template-vue-f7-split-panel

A Split View PhoneGap template using Vue.js and Framework7 that degrades to a Panel View on smaller devices
Apache License 2.0
17 stars 10 forks source link

Left Panel - Home button doesn't return the Main Panel to Home content #10

Closed hermwong closed 6 years ago

hermwong commented 6 years ago

When cycling through the buttons on the Left Panel - Home, About, Services etc...

Then click on the Home button to return to the Home page.

The Main Panel doesn't load the Home page content and just stays at the last page loaded (either the About content or Services content).

macdonst commented 6 years ago

I can reproduce this as well.

hermwong commented 6 years ago

Detailed steps to reproduce:

  1. load up the app and serve it locally
  2. you should see the Home content in the Main panel
  3. click on the hamburger menu
  4. click on the About button
  5. the Main panel will display the About content
  6. click on the hamburger menu
  7. click on the Home button
  8. the Main panel does not display the Home content

The above use case can also be reproduced by using Services button instead of the About button or if you just randomly click through About, Services and Home button.

hermwong commented 6 years ago

Looks like this is fixed with this commit: a81957c22f6380028b2214cd39360a4a060f27d6

Here is the fix: https://github.com/phonegap/phonegap-template-vue-f7-split-panel/commit/a81957c22f6380028b2214cd39360a4a060f27d6#diff-c872d58c6773db13f762a2a3eb8aefe2L8

@macdonst we must have created the template for the voice-memo-pwa right before @devgeeks made this change.

maverickmishra commented 6 years ago

The issue in the phonegap-app-voice-memos is fixed here : https://github.com/phonegap/phonegap-app-voice-memos/commit/c401399fc00ed57d9945471abac2f6a76c52b736

macdonst commented 6 years ago

@hermwong yeah, I created it off of npm which doesn't have the change.