search

phoneybadger / trimmer

A video trimming utility
GNU General Public License v3.0
9 stars 1 forks source link

Unable to trim video. Trimming throws an error #1

Open adithyankv opened 2 years ago

adithyankv commented 2 years ago

Describe the bug The video is not trimmed and the program throws an error

To Reproduce Steps to reproduce the behavior:

  1. Open a video
  2. Select start and end points
  3. Click Trim button
  4. Trim fails with error message Trim failed. Child process exited with code 1 Upon running from terminal you can see the error message 
    
[NULL @ 0x559b38605c40] Unable to find a suitable output format for 'file:///run/user/1000/doc/d8b0e6c7/test-video-trimmed-trimmed.mp4'
file:///run/user/1000/doc/d8b0e6c7/test-video-trimmed.mp4: Invalid argument

(com.github.phoneybadger.trimmer:2): CRITICAL : 23:33:20.314: TrimController.vala:132: Trim failed. Child process exited with code 1



**Expected behavior**
The trim should succeed and the video should be trimmed

**Desktop (please complete the following information):**
 - OS: elementary OS 
 - OS Version 6.1 Jólnir
 - 1.0.1
adithyankv commented 2 years ago

Installing the flatpak runtime extension org.freedesktop.Platform.ffmpeg-full seems to fix the issue. 

flatpak install org.freedesktop.Platform.ffmpeg-full

This runtime should be bundled with the application.

adithyankv commented 2 years ago

Fixed with feea257. Bundling in ffmpeg as a separate module. To automatically install an extension on app install the extension needs to be on the same remote as the app, but as the appcenter remote doesn't have the extension available, using ffmpeg bundled as a module instead.

adithyankv commented 2 years ago

Fixed with feea257. Bundling in ffmpeg as a separate module.

This solution doesn't work as ffmpeg cannot be distributed as a module along with the app through elementary appcenter due to patent restrictions in the US. Reference elementary/appcenter-reviews#343