phoreproject / graphene

Phore Synapse working repository
MIT License
13 stars 6 forks source link

Allow multiple modules to be run from a single binary #102

Closed meyer9 closed 4 years ago

meyer9 commented 4 years ago

We want to be able to run the beacon, shard, and validator modules all from the same binary.

TODO:

meyer9 commented 4 years ago

The last part of this is to implement a common interface for modules which should basically just be:

type Module interface {
    Run() error
}

Then, we should build out the synapse module which will take in just global options and run apps based on the configs provided.

codecov-io commented 4 years ago

Codecov Report

Merging #102 into master will increase coverage by 0.99%. The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   48.13%   49.13%   +0.99%     
==========================================
  Files          42       43       +1     
  Lines        4531     4441      -90     
==========================================
+ Hits         2181     2182       +1     
+ Misses       2070     1981      -89     
+ Partials      280      278       -2
Impacted Files Coverage Δ
shard/transfer/transfer_shard_code.go 16.66% <ø> (ø) :arrow_up:
beacon/syncmanager.go 0% <ø> (ø) :arrow_up:
primitives/state.go 55.07% <ø> (-0.07%) :arrow_down:
utils/net.go 0% <0%> (ø)
primitives/validator.go 88.46% <71.42%> (+6.98%) :arrow_up:
beacon/db/badger.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04ba530...b51b264. Read the comment docs.