phoreproject / graphene

Phore Synapse working repository
MIT License
13 stars 6 forks source link

Initial sync #35

Closed meyer9 closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #35 into testnet will decrease coverage by 2.51%. The diff coverage is 30.26%.

Impacted file tree graph

@@             Coverage Diff             @@
##           testnet      #35      +/-   ##
===========================================
- Coverage    54.26%   51.75%   -2.52%     
===========================================
  Files           19       19              
  Lines         2624     2817     +193     
===========================================
+ Hits          1424     1458      +34     
- Misses        1015     1168     +153     
- Partials       185      191       +6
Impacted Files Coverage Δ
csmt/node.go 100% <ø> (ø) :arrow_up:
beacon/mempool.go 0% <0%> (ø)
primitives/state.go 31.66% <0%> (-0.72%) :arrow_down:
beacon/db/badger.go 0% <0%> (ø) :arrow_up:
beacon/db/memory.go 27.27% <0%> (-2.24%) :arrow_down:
csmt/csmt.go 81% <100%> (+1.87%) :arrow_up:
beacon/blockchain.go 50.15% <41.17%> (-2.99%) :arrow_down:
beacon/statemanager.go 62.67% <68.96%> (-2.75%) :arrow_down:
beacon/state.go 64.6% <84.09%> (+19.04%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d5777a...804ad6d. Read the comment docs.

meyer9 commented 5 years ago

Fixed #12

meyer9 commented 5 years ago

Very close with this commit. There are a few weird bugs still like RANDAO signatures not validating on the "syncee" after allowing another peer to sync with them.

meyer9 commented 5 years ago

This is working pretty well now and seems ready to merge.

meyer9 commented 5 years ago

2 things to fix before merging: