search

phoreproject / graphene

Phore Synapse working repository
MIT License
13 stars 6 forks source link

#39 make dependent database operations atomic using transactions #42

Closed wqking closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #42 into master will decrease coverage by 0.38%. The diff coverage is 4.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   36.54%   36.15%   -0.39%     
==========================================
  Files          20       20              
  Lines        3336     3377      +41     
==========================================
+ Hits         1219     1221       +2     
- Misses       1979     2017      +38     
- Partials      138      139       +1
Impacted Files Coverage Δ
beacon/db/badger.go 0% <0%> (ø) :arrow_up:
beacon/state.go 61.6% <50%> (-0.39%) :arrow_down:
beacon/db/memory.go 26.47% <8.33%> (-1.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31df80c...c2c48bc. Read the comment docs.

meyer9 commented 5 years ago

Can you rebase this with master?

wqking commented 5 years ago

My bad, wrong target branch. Fixed.

meyer9 commented 5 years ago

Actually, the branch was correct. I merged testnet into master earlier. It should be based on master. Just run git rebase master.

wqking commented 5 years ago

Done

meyer9 commented 5 years ago

LGTM! There are other places where transactional database modifications are needed, but we can add those in over time.