search

phoreproject / graphene

Phore Synapse working repository
MIT License
13 stars 6 forks source link

The nodes' multiaddr address should use P2P protocol instead of IPFS? #88

Open wqking opened 4 years ago

wqking commented 4 years ago

Currently the node addresses look like /ip4/0.0.0.0/tcp/11781/ipfs/12D3KooWSzvx4mxBSGhLzqS3gLp4wrGqivLuNghZadTgH1R1fbVR, which uses IPFS protocol. There are several evidence showing that IPFS is deprecated and it's replaced by P2P.

Evidence 1, in multiformats/go-multiaddr/protocols.go source code,

P_P2P     = 0x01A5
P_IPFS    = 0x01A5 // alias for backwards compatability

Evidence 2, Python version libp2p has nothing about IPFS, and all its example and test code use p2p.

Current problem is that if we continue using IPFS, I'm not sure if py-libp2p can parse the nodes' addresses.

meyer9 commented 4 years ago

I believe this is solved by updating the LibP2P version which sort of split the main core repo into a bunch of smaller repos. The core repo is now deprecated.

wqking commented 4 years ago

OK. Are you going to upgrade libp2p or let me do it?

meyer9 commented 4 years ago

It's a fairly big change. It would probably cause lots of merge conflicts, but you can try to do it. Here's an example deprecated repo: https://github.com/libp2p/go-libp2p-interface-connmgr

wqking commented 4 years ago

OK, I will try to do it as long as we decide to do so.

wqking commented 4 years ago

Created PR #92

meyer9 commented 4 years ago

Closed. I actually wasn't just talking about updating, but it should be fine since I already made the changes on my branch.