search

phoreproject / pm-go

OpenBazaar 2.0 Server Daemon in Go
MIT License
4 stars 8 forks source link

Make invalid Multisignature address #16

Closed liray-unendlich closed 6 years ago

liray-unendlich commented 6 years ago

Brief Description: Openbazaar-go makes invalid escrow address

Operating System (OS and version): Windows8.1 Phore Marketplace version (shown on About Phore Marketplace page in menu): v1.3.3 Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always

Steps to reproduce:

  1. Choose item
  2. Click "BUY NOW" button
  3. Choose escrow payment
  4. Check escrow address

Observed Behavior: Openbazaar-go makes invalid escrow address(bc1qc~).

Expected Behavior: Valid escrow address should start from 6~

Additional info (links, images, etc go here): image This is log for openbazaar-go LOG.zip

liray-unendlich commented 6 years ago

Thanks for fixing about multisignature address. I tried escrow payment. I found there is something wrong about escrow Sellar can confirm escrow payment, and buyer can fullfilment and sellar can complete. But after order completion, escrow service doesn't send charge. I think this problem come from transaction fee and count confirmation transaction(count confirmation, not on time) After completion, sellar and buyer can't check their order like below picture. (I restart openbazaard two times) image

Here is buyer and seller ob.log buyer: buyer.log

seller: seller.log

meyer9 commented 6 years ago

Fixed b29845c6f4de3b512a5a85aa98595722be6b412d