search

phosphor-icons / homepage

The homepage of Phosphor Icons, a flexible icon family for everyone
https://phosphoricons.com
MIT License
3.89k stars 93 forks source link

Sorting icons (sort-descending and sort-ascending) mixed up #508

Closed sasweb closed 4 weeks ago

sasweb commented 4 weeks ago

Arrow for descending order (sort-descending) should point down and sort-ascending should point up. This is a common standard. Having it the other way around is very confusing.

Thanks!

rektdeckard commented 4 weeks ago

There are arguments to be made both ways and I disagree that this is established, even though I understand how it causes confusion. As discussed previously in https://github.com/phosphor-icons/core/issues/13, our understanding has always been:

The arrow points in the direction in which the sort value is increasing. For example, in Ascending order, values increase as you go down the list.

Whatever the right way is, we're not changing it now, as that would be more confusing to developers unaware of such a change and unknowingly incorporating it into applications. Hope you can live with that!

sasweb commented 4 weeks ago

Thank you for the quick feedback. Of course it's something I can and will live with.

However, for the "established" part. I have just googled "sort descending icon". 28 of the first 30 results using arrows use the arrow pointing down. 93% sounds like the standard way to me :)

rektdeckard commented 4 weeks ago

Whatever the arguments, the best solution for us is probably to rename these icons list-arrow-up and list-arrow-down. This is most in line with existing icon naming convention in the set, and is not prescriptive about use. As we typically do with renames, the existing icon names would continue to work as-is in code libraries.

Does that "scratch the itch" for you?

sasweb commented 4 weeks ago

Whatever the arguments, the best solution for us is probably to rename these icons list-arrow-up and list-arrow-down. This is most in line with existing icon naming convention in the set, and is not prescriptive about use. As we typically do with renames, the existing icon names would continue to work as-is in code libraries.

Does that "scratch the itch" for you?

Sounds great!