Add self export of package.json

phosphor-icons / react

A flexible icon family for React

https://phosphoricons.com

MIT License

1.1k stars 57 forks source link

Add self export of package.json #87

Closed hailwood closed 6 months ago

hailwood commented 6 months ago

Because of the catchall export ("./*") packages like resolve-from are unable to load the package.json.

Attempting to do so, they'll get redirected to the index.* packages. This is affecting using this package in things like storybook where we get the warning

unable to find package.json for @phosphor-icons/react

rektdeckard commented 6 months ago

Ugh, stuff like this makes me think we made a wrong turn with web dev 😅. Thanks for the fix! Any chance this could mess up module resolution anywhere?

hailwood commented 6 months ago

Aha I know that feeling!

I don't believe it will cause any issues, I made the changes locally and it didn't seem to cause any issues.