search

phosphor-icons / webcomponents

A flexible icon family for the web
Other
12 stars 2 forks source link

NPM publish? #1

Closed sjml closed 1 year ago

sjml commented 3 years ago

Hi there! Love the icon set, and am already using it in a project by hacking the SVGs directly into my code. I was starting to prep component versions of them when I saw this was already in progress. Is anything in particular preventing this from being published on NPM? Anything you need a hand with to push it over the finish line?

rektdeckard commented 3 years ago

Hey, thank so much for the interest, and for the offer! Haven't had a chance to finish it off, but I'd love some contribution! This is really my first foray into web components, so feel free to suggest a better way of doing things if you see one.

sjml commented 3 years ago

I haven't tried using this setup yet, but will install direct from the repo and see how it flies. :)

rektdeckard commented 3 years ago

If I recall there were some quirks with passing SVG namespaced elements into the <slot> but I'll have to take a look again to remember what was up with that. Besides that, I think it's pretty close. Will try to get to it this weekend.

rektdeckard commented 3 years ago

Also would like to set it up for code-splitting.

rektdeckard commented 3 years ago

After a little digging today, I'd say the only thing really missing is library-supported tree shaking, since it seems the web components spec does not support slotted SVG-namespaced elements. In light of that, I think I'm going to hit publish and deal with that later...

SebastianGarces commented 3 years ago

Hi there, any update on this? :)

rektdeckard commented 1 year ago

Package has finally been published at long last 😅 @phosphor-icons/webcomponents Feedback welcome, as I'm not too up on the Web Components ecosystem.

aarongerig commented 1 year ago

@rektdeckard Thank you for your work! Phosphor Icons as a library looks very promising and we are planning to use it for our new website. There we'd like to integrate the icons as web components, so I can definitely give you some feedback on that, once we start working on the integration (Q3/Q4 of 2023).