search

photo / frontend

The official @github repository of the Trovebox frontend software. A photo sharing and photo management web interface for data stored "in the cloud" (i.e. Amazon S3, Rackspace CloudFiles, Google Storage).
https://trovebox.com
Apache License 2.0
1.37k stars 244 forks source link

Mozilla Persona button is not shown consistently #1225

Open wanderview opened 11 years ago

wanderview commented 11 years ago

Currently it seems the Mozilla Persona button is not consistently shown. The button appears on per-account pages such as:

https://current.trovebox.com/user/login

Which is reached from the "Sign In" button on the per-account page current.trovebox.com.

Mozilla Persona, however, is not shown when you you click the "Sign In" or "Sign Up" buttons on the main trovebox.com site:

https://trovebox.com/signin https://trovebox.com/signup/free

This is extra confusing because the Mozilla Persona website links to current.trovebox.com which does not redirect to your account after you login. You remain at the current.trovebox.com per-account site.

It would be nice if the user experience could be more consistent between these different pages. If that was the case, we could then open a ticket on mozilla/browserid to update their link to the trovebox front page.

dholbert commented 11 years ago

I now see a "You can also sign in using... [Mozilla Persona]" chunk at https://trovebox.com/signin, but the button appears to be non-functional. (I tested w/ Firefox 20 and Nightly)

dholbert commented 11 years ago

(From glancing at the page source, it looks like https://current.trovebox.com/user/login (the page with a functional button) has a script tag pointing to https://login.persona.org/include.js , right after the "Mozilla Persona" button. Whereas, https://trovebox.com/signin has no such script tag anywhere on the page, as far as I can tell.)

jmathai commented 11 years ago

We are adding Persona to the main site but the button wasn't supposed to be visible yet. Pushing a fix while we complete the integration.

On Sunday, April 21, 2013, Ben Kelly wrote:

Currently it seems the Mozilla Persona button is not consistently shown. The button appears on per-account pages such as:

https://current.trovebox.com/user/login

Which is reached from the "Sign In" button on the per-account page current.trovebox.com.

Mozilla Persona, however, is not shown when you you click the "Sign In" or "Sign Up" buttons on the main trovebox.com site:

https://trovebox.com/signin https://trovebox.com/signup/free

This is extra confusing because the Mozilla Personahttps://login.persona.org/aboutwebsite links to current.trovebox.com which does not redirect to your account after you login. You remain at the current.trovebox.com per-account site.

It would be nice if the user experience could be more consistent between these different pages. If that was the case, we could then open a ticket on mozilla/browserid to update their link to the trovebox front page.

— Reply to this email directly or view it on GitHubhttps://github.com/photo/frontend/issues/1225 .

-- Snet form my mobl phoone

dholbert commented 11 years ago

Ah, that's good to hear - thanks!

hfiguiere commented 11 years ago

This is what causes bug #1284, isn't it?

jmathai commented 11 years ago

@hfiguiere No, this is for the signup on Trovebox.com

https://trovebox.com/signin

hfiguiere commented 11 years ago

ah ok.