search

photo / frontend

The official @github repository of the Trovebox frontend software. A photo sharing and photo management web interface for data stored "in the cloud" (i.e. Amazon S3, Rackspace CloudFiles, Google Storage).
https://trovebox.com
Apache License 2.0
1.38k stars 244 forks source link

Add swipe events to the js library #280

Open jmathai opened 12 years ago

jmathai commented 12 years ago

We should be able to subscribe to swipe actions for mobile devices. The most common use would be to paginate through pages. Ideally we could just add a class to the "next"/"previous" links which bind the swipe action and trigger something which loads that elements href.

@erudianart, thoughts on this?

erudianart commented 12 years ago

Agreed, jQuery and YUI have swipe events so I can easily add this. Will be working on Openphoto this weekend! Sorry for the delay (but you know why :P)

jmathai commented 12 years ago

@erudianart, Any ETA on when you'll have time to add this?

erudianart commented 12 years ago

Looking into this right meow.

erudianart commented 12 years ago

@jmathai - it requires a jQuery plugin, do we want the library to detect / determine if we are on a mobile browser and load plugins where necessary?

erudianart commented 12 years ago

hmm so how does photoswipe integrate currently? It looks like it has that functionality already, do we want to pull that out into the util and make it a little more generic or are we only thinking about prev / next for images. Also, should we enforce the inclusion of a mobile framework for swiping (jQuery mobile) or should we just write it ourselves?

jmathai commented 12 years ago

If PhotoSwipe has a good swipe library then we can use it. But I don't think we should use it simply because it's in PhotoSwipe.

I do think we should include it by default so theme makers don't have to think about it. If that's jQuery Mobile and a YUI equivalent then that's fine with me.

Also, the latest default mobile theme is not using PhotoSwipe.

erudianart commented 12 years ago

Hmm i may need to chat with you about the mobile theme, looking over the code it is a wee bit confusing.

jmathai commented 12 years ago

@erudianart, Okay, whenever you want I can chat. I'm on Eastern time this week though. The mobile stuff was done by a volunteer but we can modify it as needed.

erudianart commented 12 years ago

Are you back this weekend? Maybe Sunday we can chat?

jmathai commented 12 years ago

I can chat Sunday or Friday. Let me know what works for you.

erudianart commented 12 years ago

Sunday sounds great to me! Friday I won't be able to chat until after work so if you are on eastern time that probably won't work.

jmathai commented 12 years ago

Sunday it is. Around 1pm will probably be good for me.

jmathai commented 12 years ago

@erudianart is in Shanghai so deprioritizing for now.