search

photo / frontend

The official @github repository of the Trovebox frontend software. A photo sharing and photo management web interface for data stored "in the cloud" (i.e. Amazon S3, Rackspace CloudFiles, Google Storage).
https://trovebox.com
Apache License 2.0
1.37k stars 244 forks source link

The gallery should not show the pictures in a lightbox #636

Open hfiguiere opened 12 years ago

hfiguiere commented 12 years ago

When viewing the gallery ( /photos/list ), clicking on a picture should not show a lightbox. One of the reason is that in that lightbox clicking on the next picture show it in the whole window (normal). Also the lightbox is confusing IMHO.

hfiguiere commented 12 years ago

Updated issue, I totally missed the "not" making it the opposite that I wanted.

jmathai commented 12 years ago

From the /photos/list page if you click on a thumbnail it will open the lightbox. Clicking the right/left arrows or the next/previous thumbnail will advance to the photo in the lightbox. If you click on the "arrow" then it does a full page reload.

The reason for the lightbox is to make viewing photos easier. If it did a full page reload then you'd have to go back to the list of photos if you only wanted to look at one photo and you'd often lose context. I'm open to making this experience better but doing full page reloads, I don't think is better than the lightbox.

This is especially true since the beisel2.0 theme uses infinite scrolling.

jordanbrock commented 12 years ago

I like the idea of the lightbox, but perhaps if all of the extra information was removed, and it was just the photo displayed, along with a link to the full page for that photo? So it works more like a preview.

Maybe if you had the next/previous thumbnail (We need a name for this widget), a link to the main photo page and not much else?

jmathai commented 12 years ago

@jordanbrock That's a a good idea. Let me see how that feels to browse.

hfiguiere commented 12 years ago

And please, make it DARK.

hfiguiere commented 12 years ago

Also please fix issue #601 which is also why I can't use it.

jmathai commented 12 years ago

@jordanbrock / @hfiguiere what do you think with the comment form removed?

jordanbrock commented 12 years ago

I like it without the comment form. Ideally I'd remove even more stuff, but that's probably just me. Not sure.

Not sure if you want a new ticket for this or not, but in the Next/Previous widget, clicking the photo updates the lightbox whereas clicking on an arrow goes to the photo page.

And can you make the actual photo in the lightbox a link to the photo page? Currently there's no easy way to get there.

jordanbrock commented 12 years ago

OK. RE the images widget. It works now. Ignore that part of my previous comment. Sorry.

jmathai commented 12 years ago

I really like how Google Plus integrates comments into the lightbox. They do it in a way that doesn't clutter or distract. Perhaps we can include the comments along the right and remove the other stuff.

These are pretty high level design decisions though. We should take some time to think about it but I believe comments are pretty high value. If someone else is viewing your photos then they might want to comment. If you're viewing your own you're probably just in "browse" mode.

This is why i think the G+ layout works for both...very little clutter, focuses on the photo and has the option to comment. Might have to give those requirements to a designer instead of fiddle with it myself.

okpierre commented 12 years ago

The main photo page already contains all the details so showing it again in lightbox takes away from the main focus which is the photo along with the discussion of the photo. I vote for the G+ layout as it is simple and to the point. With the comments to the side instead of the bottom, the photo is still in view instead of having to scroll to the bottom.

tommyla commented 12 years ago

what about adding "enable lightbox" in settings? that way some people can have it and some can disable it, and everyone is happy

jmathai commented 12 years ago

@tommyla I think the real solution is a better approach that doesn't use the lightbox at all.

The reason for the lightbox is to retain context and we can do a better job at that without resorting to a lightbox.

oscherler commented 12 years ago

To chime in: the reason I never signed up for Flickr is that I wanted a web site to show my pictures, not a website to show the Flickr interface and incidentally, if you look carefully, a postage-stamp–sized version of my images. So it would be nice to have, in addition to a photo page with all the details and comments, a view dedicated to the photo: dark, with little distraction and browsing without full page loads. But as Jaisen said, they’re high-level design decision and deserve proper thinking.

It’s not a huge issue for me at the moment, as I chose OpenPhoto because I can use it to store and organise my photos, and then use the API to retrieve them elsewhere and display them in the minimalistic view I like. (I have a tiny Ruby/Sinatra app that lists my tags in the backend and lets me generate albums out of them, that I display using Galleria in the frontend.)

hfiguiere commented 12 years ago

That's why I still use the "default" theme.

hfiguiere commented 12 years ago

And BTW, you know you also have the option to write a new theme.

pmario commented 12 years ago

@hfiguiere

And BTW, you know you also have the option to write a new theme.

Is there a "white paper", how the actual theme navigation should work?

jmathai commented 12 years ago

@pmario Do you mean documentation on how to create themes? Not yet. We're just starting on documentation for developers. These are drafts so you're more than welcome to provide input. Not much there about themes...

pmario commented 12 years ago

yup. I thought some docs / drafts about the original intentions / workflow ... would be fine.

As I found openphoto I was happy so see http://theopenphotoproject.org/documentation. This project seems to be the first one, that starts with a propper public API and then builds around it.

I like the user landing page, with the "homeCarousel". What I'd want to change is the behaviour of the "thumbnail click". For me the landing page is a presentation page. If I click a thumb, I want to display the picture inside the carusel. If the thumbs navigate the carusel seems to be more natural to me.

If I click the big picture inside the carusel, I want to open a "full screen viewer", which shows a slideshow. I'd like to use http://buildinternet.com/project/supersized/ which imo is very nice.

Same with "Gallery, Album, Tags" views. Absolutely the same behaviour, to be consistent.

In "Gallery, Album, Tags" view I'd like to add a clickable "(i) info" button to the thumb, that opens the picture meta view. Similar to the lightbox, that opens now but including the comment possibility, (if commenting is allowed by the owner - which is probably a feature request).

jmathai commented 12 years ago

As I found openphoto I was happy so see http://theopenphotoproject.org/documentation. This project seems to be the first one, that starts with a propper public API and then builds around it.

Glad it doesn't go unnoticed :). Every feature we build actually requires the API to be built before any UI. You can grep for invoke( in the source code to see where the app calls its own API.

jmathai commented 10 years ago

@hfiguiere is this still a valid issue? It was originally talking about the lightbox in the Beisel2.0 theme which was atrocious. I think the current Lightbox is better but it's also the first UI view I want to remove as much as possible from (see issue #1531).

hfiguiere commented 10 years ago

Yes by default it still sends me to the lightbox from the gallery. On 4.0.0rc6

hfiguiere commented 10 years ago

If I click on "Full details" I get the other view.

jmathai commented 10 years ago

There are a few issues related to making the experience better (#1538, #1534, #1531). What I'm thinking is to make the gallery open the lightbox by default which would be optimized for viewing. The edit/manage functionality would be removed and focused on the photo detail page.

To get directly to the photo detail page there will probably be an icon on the photo to click.

jmathai commented 10 years ago

@hfiguiere 4.0.0-rc6 won't get any additional functional changes. The changes I'm referring to are in master.