Normalize sort options for gallery view [WAS: Sort Option For Gallery View]

[okpierre]

I find the sorting of the photos a bit odd for the Gallery view.

Currently it sorts in this odd order 6 7 8 9 1 2 3 4 5

Shouldn't it be a choice like this based on newest (9) to oldest (1) 9 8 7 6 5 4 3 2 1

or from oldest (1) to newest (9) 1 2 3 4 5 6 7 8 9

[patricksan]

@okpierre, the sort is based in the photo taken date, not the uploaded date. Do you still see the behavior there?

[okpierre]

I was wondering that myself but if the photos do not have date taken, what would it use then? I guess my issue is a wishlist (feature request) and bug report. :)

[patricksan]

Give a look at: https://github.com/openphoto/frontend/issues/262

[hfiguiere]

it would use the upload date if there is no Exif for the date taken.

I have a patch locally to sort by upload date and I fixed some stuff in the MySQL adapter to have it work (this last bit is in the official tree)

[jmathai]

@okpierre The sort order logic are these, in order:

1. Sort by day taken desc
2. Sort by time of day taken asc

This puts the photos in chronological order (oldest to newest) grouped by day (newest to oldest).

The biggest issue with sort options is query optimization. I actually removed some of the sort options we had because the queries were horribly inefficient. I guess it doesn't matter so much on a self installed instance with just a few thousand photos but it's a bigger task we have to resolve.

[okpierre]

Thanks for the details everyone.

desc (9 8 7 6 5 4 3 2 1) and asc (1 2 3 4 5 6 7 8 9) makes sense

@hfiguiere are you saying the patch fixes openphoto sorting 6 7 8 9 1 2 3 4 5 or is it a different bug?

[hfiguiere]

what is these 6 7 8 9 1 2 3 4 5 ? date taken or date uploaded?

[okpierre]

Sorry if my explanation wasn't clear

a b c d e f g h i (gallery position) 6 7 8 9 1 2 3 4 5

On first day, photos 1-5 were uploaded. Another day, photos 6-9 were uploaded. 1 = first photo uploaded but it is placed in position 'e' instead of 'i' 2 = second photo uploaded but it is placed in position 'f' instead of 'h' ... 6 = sixth photo overall to be uploaded but not the same day. Should be in position 'd' instead of 'a', right? etc. etc.

[hfiguiere]

So you complain is that they are ordered by date taken instead of date uploaded. Yes that's the only current behaviour.

[okpierre]

I'm not complaining. I'm testing and reporting what I find to be issues. I guess my explanation is confusing and I'm the only person experiencing this issue with the development and the master branch. I'll give it another try when the next update is released.

[Notmarrco]

I also find the sort order :

1. Sort by day taken desc
2. Sort by time of day taken asc quite confusing.

Wouldn't it be more logical to have :

1. Sort by day taken desc
2. Sort by time of day taken desc ?

My guess is that @okpierre doesn't experience any issue on the sorting but he's just as confused as I am when I look at my photos in this order. Maybe can we make it customisable : 'asc' or 'desc' ?

[jmathai]

@Notmarrco Not sure there's a right answer for which is more logical. I'd argue the current way is more logical but of course I would since I did it :). I agree that we should have more sorting options though. The biggest question becomes what is the default?

[nicokaiser]

I also agree it would be way more logical and less confusing if there was no grouping by day.

Especially when navigating through albums (with photos from many days) the order is completely confused by this. IMO the default (!) order should be

• Sort by date taken (not grouped by day) descending at the gallery page (or maybe date uploaded desc)
• Sort by date taken (not grouped by day) ascending at the album page

Once the order can be configured per album, the user can change this anyway. Maybe add an ini setting for now?

[jmathai]

Taking a step back and opening this up for discussion with the hopes that we can decide on a good default based on all the perspectives we get. #1341