search

photo / mobile-android

Trovebox mobile application for Android
Apache License 2.0
120 stars 64 forks source link

Fix problems with upload #456

Open patricksan opened 10 years ago

patricksan commented 10 years ago

We need to implement these actions:

  1. Upload when connected to wifi only should be the default option
  2. When an image fails to upload, do not try to upload it again unless prompted by the user
patricksan commented 10 years ago

@httpdispatch can you check this? First the item 2, please.

@jmathai, I don't like the first one. That means that user would not be able to send images in the 3G until he changes the default option.

jmathai commented 10 years ago

I meant just for auto upload.

patricksan commented 10 years ago

@jmathai, in that case I also agree. @httpdispatch

httpdispatch commented 10 years ago

The application doesn't have a place where user can retry failed uploads manually except it clicks on failed notification and presses upload button again in the upload activity. Also if upload fails it will not retry immediately until app restart or connectivity state changed or user will upload new photo. So i need some more explanation for item 2

As for the first item. When we added the option we had a discussion about autoupload/regular upload. The thing is that both uploads uses same queue and we don't separate them there. Upload process is automatic and if it fails it will start again on connectivity state changed. If user has regular and autouploads in the queue which failed for the first time or connection was absent when they were added and user connects to 3G both regular and automatically added images will retry to reupload if no WiFi only upload option is specified. So the first item also requires some clarification