photo / openphoto-wordpress

A WordPress plugin for OpenPhoto
http://theopenphotoproject.org
22 stars 8 forks source link

Link to larger version should not be to the original #3

Closed jmathai closed 12 years ago

jmathai commented 12 years ago

When embedded the link should go to a lower resolution version than the original. Perhaps 1280x1280 or something.

randyjensen commented 12 years ago

We tried to keep as much of the OP plugin as similar to the way the WP media uploader works. Since that links to the actual image, we figured we should do the same. It seems to make the most sense to link to the actual OP page for the image, so hopefully most people will do that.

We can certainly change the link to link to a smaller version, but that was the thought process behind linking to the full sized image.

jmathai commented 12 years ago

@randyjensen That's an interesting point. I didn't mean to link to the OP page for the image but that's something to consider. But if there's already a standard for WP then I agree we should use that. Can we instead of linking to the original photo link to a larger lowres photo (not the OP page for it)? ... path1280x1280, for example.

randyhoyt commented 12 years ago

WordPress has three buttons for selecting where an image should link: (1) no link, (2) the raw file for the original photo, and (3) a web page that contains the image and could (if the theme supports it) allow site visitors to leave a comment on the photo. We have matched that functionality in the plugin. We also have three buttons: (1) no link, (2) the raw file for the original photo, and (3) the OpenPhoto page that contains the image and allows site visitors to leave a comment on the photo.

I'd like to keep it as it is. What's the benefit of linking to a lower resolution version of the image than the original?

jmathai commented 12 years ago

@randyhoyt Makes sense. I'm less familiar with the world of Wordpress but it looks like the standards are already there and you're following them :).

I guess the user is explicitly choosing to share the original.

Should I include the "web page url" of the photo in the API response?

randyhoyt commented 12 years ago

Yes, please include the "web page url" in the API. We're piecing it together right now, concatenating "http://" and appId and pathOriginal.