Closed EmperorArthur closed 3 years ago
This import was removed there: https://github.com/photocrowd/django-cursor-pagination/commit/1ebc4aba54d84ac4359cd38b81c3cc4ee659bd61#diff-0ce18fd053e85c304cc64c8258cf448b716a509280048d7b84fc76b9e590c317 so maybe you can install via that commit until a new version is made?
Any idea when will this be fixed?
@Drarok @mjtamlyn @patrick91 any chance we can get a new version 0.1.5 released? The fix for this issue is already merged onto master.
@lvieirajr I'm sorry but I don't have permession to release, I was consindering making a new package/fork to keep it alive.
Who are the people that can make the releases? Are they just not maintaining this anymore? Could you at least get them to give you access to make the release so this doesn't die?
@patrick91 I don't have commit access to this repo anymore, but I am still listed as an owner of the package on pypi. I can add you as a maintainer, what's your username?
Edit: There's a patrick91
user with the same profile picture, I assume that's you.
@Drarok yes, that's me :)
Got access! I'll try to make a release by the end of the weekend!
Hey @patrick91 ; do you have any future plans for that repos; or will you only do a one-off release to address the problem from that issue?
If you plan on being a maintained; there is a couple of features I would love to help building
@dorian-writes-code I'm happy to maintain it, but I don't think I'll work on any new features personally.
Happy to review your PRs though! What did you have in mind?
One issue I've had is that when ordering a column from the highest value to the lowest; NULL
values from the column would appear first.
With order_by
; it's possible to choose if the null
should be first or last (https://docs.djangoproject.com/en/3.2/ref/models/querysets/#order-by); so I would like to be able to have that option in django-cursor-pagination
Yay @patrick91 the savior! Thanks @Drarok
Release ready here: https://pypi.org/project/django-cursor-pagination/0.1.5/
let me know if there's any issue 😊
Hello, This package is broken on Django version 3.1.7. Which is at least the latest stable release of Django.
Example code:
Result:
"ImportError: cannot import name 'six' from 'django.utils'"
Expected Result:
CursorPaginator imported successfully.