photoneo / phoxi_camera

ROS Package for PhoXi Scanner/Camera. If you like us, STAR US! :P
MIT License
44 stars 32 forks source link

Fully support colorcam also on the PhoXi Page [BIPI-6009] #66

Closed ZuzanaMikulova closed 1 year ago

ZuzanaMikulova commented 1 year ago

Colorcam support has been added to BPS PhoXi page similarly as to BPS Calibration (#722).

TEST

  1. Use available colorcam.
  2. As shown in BIPI-6009, open PhoXi page in BPS, select the colorcam and connect to it. Switch view to Texture and see whether the color image is displayed correctly.
  3. For the verification, connect also to any available basic scanner from the list and see whether grayscale texture is also displayed correctly.
mikiPhotoneo commented 1 year ago

According to this analysis https://photoneo.atlassian.net/browse/BIPI-6009?focusedCommentId=268989 I would say we can merge it :) let's leave smart and beautiful texture visualization for PhoXiControl, I think in most datasets it looks great even in bps.