search

photonixapp / photonix

A modern, web-based photo management server. Run it on your home server and it will let you find the right photo from your collection on any device. Smart filtering is made possible by object recognition, face recognition, location awareness, color analysis and other ML algorithms.
https://photonix.org/
GNU Affero General Public License v3.0
1.85k stars 125 forks source link

Edit photo tags and metadata #41

Open LukeDeaves opened 5 years ago

LukeDeaves commented 5 years ago

Ability to add or remove tags that have been assigned to an image within an edit mode. Perhaps separate tags or 'album' grouping?

Able to manually add location data for photos that don't have it in the metadata. Would it be possible to edit the photos metadata in this case?

damianmoore commented 5 years ago

Yep, this will be good to have once we have the PhotoDetail screen fleshed out a bit. Once we display the metadata nicely in #4 the UI will lend itself to editing.

LukeDeaves commented 5 years ago

It's not necessarily metadata related, but under Cameras, mine appear as

SONY DSLR-A350 samsung SM-G960F motorola Moto C

Could it be that the photo manager reads the meta tag for SONY DSLR-A350 and then displays a custom name that I set for that tag, i.e. Sony a350. Similarly samsung SM-G960F could be displayed as it's more commonly known, Samsung S9.

damianmoore commented 5 years ago

Would you be able to attach a sample photo from each device please and I'll have a look at whether there are more suitable names in the metadata or a lookup table to map names to more user-friendly ones?

damianmoore commented 5 years ago

Sorry, my previous message should have mentioned you, @Soharic.

LukeDeaves commented 5 years ago

@damianmoore For simplicity I uploaded them to a dummy branch on GitHub, see: https://github.com/Soharic/photo-manager/commit/58ee23e2db1397ac0e27161c5616015fd113cd27

damianmoore commented 5 years ago

Thanks for sending the sample photos, @Soharic. There doesn't seem to be any better camera metadata in there. I think it would be good for users to set custom override names for their cameras though so I'll add a feature enhancement ticket for it.

LukeDeaves commented 5 years ago

@damianmoore That's okay; you can see the really exciting things I take pictures of!..

To an extent, the same situation occur with lenses, although I appreciate these are more technical in their namings in the first place.

Specifically, I have an 18-55mm lens and a 75-300mm for my Sony a350. The 18-55mm names itself as "Sony DT 18-55mm F3.5-5.6 SAM II (SAL18552)" which is easy enough to understand, but personally I'd use something different given the choice; probably "Sony 18-55mm F3.5-5.6" or even just "Sony a350 18-55mm"

MrColumbo commented 3 years ago

I am wondering if rating will be also part of the metadata. Many apps use that 5 star rating which is nice to step by step group photos in keepers and the ones you will delete at some point of time.

MrColumbo commented 3 years ago

Another question: Will it be possible to save the metadata as exif or xmp in the photo itself? At this point of time all the data like object detection things seems to be stored in the database. I would like to have the ability to save them in the photos itself.

nomandera commented 3 years ago

Strongly agree with this.

XMP has become the de-facto standard for tag sharing and avoiding vendor lock-in an especially sensitive topic given long term services like Google photos changing and FOSS projects like https://github.com/hooram/ownphotos dieing on the vine.

It also lets other tools contribute to tagging allowing each project to focus on that they do best and care about.

damianmoore commented 3 years ago

@MrColumbo, @anoma great feedback. Will definitely aim to add option of storing metadata back into the photo. Wouldn't want to change people's files by default but think it should be an option on the library.

damianmoore commented 3 years ago

@MrColumbo star rating feature has now made it to master branch thanks to @GyanP. It can be tried out on the demo site.