Closed robwalton closed 4 years ago
This is an impressive contribution. Thanks, @robwalton !
Awesome - thank you for the contribution Rob. Amazing work! (Also, apologies for the delayed response - I didn't realize you made a pull request until today!)
No worries. The unit tests are not quite right in the pull request and are too loose. I think the original may her been a bit loose too. Have slightly moved on from this, but will see if I can find the branch where I fixed them!
Hi Nikola,
Thanks for sharing this. I've looked around for a well tested and commented prolog implementation in Python and landed with yours. I will be calling it programatically and so dived in a little to check out the source.
I've made what look like a lot of changes to make the code meed style guidelines and to streamline the way it reads a little. Basically this pull request:
black
)pytest
unit testingThese changes do not change the logic in any way! I hope you think they are mostly improvements.