search

photostructure / exiftool-vendored.js

Fast, cross-platform Node.js access to ExifTool
https://photostructure.github.io/exiftool-vendored.js/
MIT License
405 stars 37 forks source link

Draft: First try at parsing the timezone information for the sony A7 camera #188

Open fwsmit opened 3 weeks ago

fwsmit commented 3 weeks ago

I'm working on creating a PR to fix #187. I've never used typescript before, so I need some help. How can I run the tests in this repository? I could not find documentation about that.

I know that there should be some more code to only do this for some Sony camera's, but first I wanted to check if this works. What would be a reasonable include-list? Only my model of Sony camera (ICLE-7)?

mceachen commented 3 weeks ago

How can I run the tests in this repository?

yarn test

(you may need to install a recent version of Node.js and run npm i -g yarn).

What would be a reasonable include-list?

It might be safe enough to put this at the very bottom of the timezone inference heuristics -- we'd certainly prefer something like GPS or an explicit TimezoneOffset over this wholly-undocumented, might-be-in-UTC-but-who-knows sony-specific tag.

Also: the tag name will be CamelCased (like all others). Use exiftool -j -struct $file to see what this library is seeing (ish).

fwsmit commented 2 weeks ago

How can I run the tests in this repository?

yarn test

(you may need to install a recent version of Node.js and run npm i -g yarn).

Thank you. I also needed to do a yarn install or npm install and install perl. It would be nice if there was some documenation for how to setup a developer environment.

What would be a reasonable include-list?

It might be safe enough to put this at the very bottom of the timezone inference heuristics -- we'd certainly prefer something like GPS or an explicit TimezoneOffset over this wholly-undocumented, might-be-in-UTC-but-who-knows sony-specific tag.

Also: the tag name will be CamelCased (like all others). Use exiftool -j -struct $file to see what this library is seeing (ish).

I made the name camel cased and added it to the end of the list. Now all tests pass. I don't know what a reasonable test would be to add here, since I'm just adding another name of a UTC tag. Would it be possible to test this on an actual image from my camera?

fwsmit commented 1 week ago

Hi, any chance you could take a look at this PR?