Refactoring of perceptual metrics - Githubissues

photosynthesis-team / piq

Measures and metrics for image2image tasks. PyTorch.

Apache License 2.0

1.32k stars 114 forks source link

Refactoring of perceptual metrics #291

Open zakajd opened 2 years ago

zakajd commented 2 years ago

Closes #261

Proposed Changes

[x] Move LPIPS and DISTS into separate files
[x] Mover test for LPIPS and DISTS into separate files
[x] Do not inherit LPIPS and DISTS from StyleLoss class and re-implement all required (and simplified!) logic inside them
[x] Add enable_grad flag to enable or disable gradients computation. Useful when using them as metrics, not loss functions.
[x] Add tests to compare with reference implementations.
[ ] Validate why results of our LPIPS and original one differ
[ ] Validate failing test in DISTS

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication