photosynthesis-team / piq

Measures and metrics for image2image tasks. PyTorch.
Apache License 2.0
1.41k stars 120 forks source link

Re-write function for patch cropping to return an iterator #298

Closed zakajd closed 2 years ago

zakajd commented 2 years ago

Closes #282

Proposed Changes

Pros: Memory consumption is significantly reduced, especially for large images

Cons: Inference time is also significantly increased.

After internal discussion decided to leave everything as is. For large images it's recommended to use higher values of PieAPP stride parameter.

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication