photosynthesis-team / piq

Measures and metrics for image2image tasks. PyTorch.
Apache License 2.0
1.32k stars 114 forks source link

Fix Exceptions for DSS, GMSD, Haarpsi, MS-SSIM, Perceptual, SRSIM, SSIM, VIF #305

Closed denproc closed 2 years ago

denproc commented 2 years ago

Closes #304

Proposed Changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #305 (f6e3d8e) into master (53c6b85) will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   91.02%   91.12%   +0.10%     
==========================================
  Files          33       33              
  Lines        2284     2277       -7     
==========================================
- Hits         2079     2075       -4     
+ Misses        205      202       -3     
Flag Coverage Δ
unittests 91.12% <100.00%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/fid.py 92.72% <ø> (+1.49%) :arrow_up:
piq/kid.py 90.42% <ø> (+1.65%) :arrow_up:
piq/dss.py 100.00% <100.00%> (ø)
piq/perceptual.py 100.00% <100.00%> (ø)
piq/srsim.py 99.00% <100.00%> (ø)
piq/ssim.py 100.00% <100.00%> (ø)
snk4tr commented 2 years ago

@denproc thanks for the PR. As you see from the review, I think that several changes that you proposed are not actually required. Let me know what you think. There are several nice catches though 👍 .

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication