Photo/Video viewer redesign

photoview / photoview-ios

iOS client for Photoview

https://apps.apple.com/dk/app/photoview-media-gallery/id1578380271

GNU General Public License v3.0

23 stars 6 forks source link

Photo/Video viewer redesign #20

Open ddshd opened 1 year ago

ddshd commented 1 year ago

Images now open to the full screen view
Navigation Buttons to take users to the details/download page
Full screen video (Contains PIP support)
Overall updates to make it work like a standard photos app

This should addresses the requests and concerns people had with the image viewer. Let me know if you'd like me to add some demo images/videos to this PR. Will need to setup a test user but I can make it happen.

Addresses: #19, #15, #4

viktorstrate commented 1 year ago

Thank you for your efforts! Let me know when you feel the PR is ready for review. If you can (maybe with screenshots or video) describe the changes you've made and show how to test them, it will help really help out.

ddshd commented 1 year ago

The PR is ready for review.. I've added a demo video, it should showcase:

Pinch to scroll
Scrolling through media
Video player
PIP Video player
The info/details screen (I didn't have a sample image with exif data, however, it will appear above the Download options. This should be somewhat visible at 1:02)
Integration with the timeline (The same behavior when tapped from Places, or Faces views)

The video is compressed because of GIthub's file limit: https://user-images.githubusercontent.com/17243132/223235037-a34a3c15-cd37-4c5d-a6de-a69fd10d97d8.mp4

apat183 commented 1 year ago

This is great update. Just came here to request this as a new PhotoView user. Can't wait for this to be merged

ghost commented 1 year ago

Any update on when this will be merged? I'd love to see these changes implemented into the app! :)

PubBow commented 9 months ago

Not sure if this is the right place to comment. I have just started using Photoview and it's a great product so I signed up to Git just to comment.

I had some issues with the manual install documentation but got it working.

As mentioned by @apat183 - looking forward to the iOS update to make the app a standard photos app which is currently letting the product down.