search

php-actions / php-build

Fast builds for repositories using php-actions.
9 stars 9 forks source link

Optional PHP version check #19

Open MarcHagen opened 3 months ago

MarcHagen commented 3 months ago

https://github.com/php-actions/php-build/blob/79797dbe75def0a196c778c9471692352ab06c9b/php-build.bash#L111

This line causes docker to pull the PHP image from Docker Hub. Meaning this pull is counting too the Rate Limits set by Docker Hub. We have quite a few CIs running, and when multiple PRs are open, it sometimes hits the Docker Hub rate-limit on self-hosted runners.

Is it possible to make this check optional, so the CI runs will not fail hard on this?

Status: Downloaded newer image for docker.pkg.github.com/someorg/somerepo/php-actions_composer_somerepo:php-8.1-dom-curl-libxml-mbstring-zip-pcntl-pdo-pdo_mysql-ssh2-snmp-json-ftp-openssl-build2.2.1
docker.pkg.github.com/someorg/somerepo/php-actions_composer_somerepo:php-8.1-dom-curl-libxml-mbstring-zip-pcntl-pdo-pdo_mysql-ssh2-snmp-json-ftp-openssl-build2.2.1
Pulling php:8.1-cli-alpine
Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
<exit>