Closed osma closed 3 years ago
Hi @osma,
Thank you for this PR. For some reason I had assumed that PHPUnit runs with a default of 512M, but I can't find where I got this information from (and it's obviously not the case).
I think updating the README here makes the most sense.
Thanks again, Greg.
I'm using php-actions/phpunit without setting a
memory_limit
. When I enabled thepcov
extension to collect code coverage information (which uses more memory than before), my tests started failing with errors like this:The current README.md states that the default
memory_limit
is 512M but this doesn't seem to be the case, as the actual memory limit is 128M according to the above error messages. There is no default value for the memory_limit setting in action.yml so I guess that the default value comes from PHP itself. Setting memory_limit to 512M fixed the problem with my tests.This PR changes the README to state the correct default value for memory_limit. An alternative would be to set a default value of 512M in action.yml, so that reality would then correspond to the documentation.