search

php-actions / phpunit

Run PHPUnit tests in Github Actions.
108 stars 24 forks source link

Need to whitelist `php_extensions` as it's giving a false positive warning message #55

Closed summercms closed 1 year ago

summercms commented 1 year ago

This warning message seems to suggest there's an error in this repo

Warning: Unexpected input(s) 'php_extensions', valid inputs are ['entryPoint', 'args', 'configuration', 'log_junit', 'log_teamcity', 'testdox_html', 'testdox_text', 'testdox_xml', 'memory_limit', 'bootstrap', 'filter', 'testsuite', 'group', 'exclude_group', 'test_suffix', 'whitelist']

My code is:

      - name: "PHPUnit Tests"
        uses: "php-actions/phpunit@v9"
        with:
          php_extensions: "xdebug pcntl"
          bootstrap: "vendor/autoload.php"
          configuration: "phpunit.xml.dist"
          args: "--coverage-text"
          memory_limit: "256M"
        env:
          XDEBUG_MODE: "coverage"
          TEST_NAME: "Summer CMS"
g105b commented 1 year ago

Hi, I believe this is a versioning issue. Please read this paragraph: https://github.com/php-actions/phpunit#github-actions-releases

Originally, the Github Action attempted to make a release with the same number as PHPUnit made a release, but this was impossible to manage, so we reset to v1 in 2021. Now the latest release is v3 and that should work for you. I only intended to keep these old references for 1 year after the change, but I never got around to removing them. Seeing as it's caused confusion here, I'm going to remove them today.

Thanks!

summercms commented 1 year ago

Thanks, will switch to v3.

I will leave this issue open, as the readme.md is a bit confusing - because I read the sections: Inputs and PHP and PHPUnit versions which didn't link to the section below: Github Actions releases.

g105b commented 1 year ago

Thanks, I'll update to make it more readable.

g105b commented 1 year ago

Removed out-of-order tags: https://github.com/php-actions/phpunit/tags