search

php-amqplib / RabbitMqBundle

RabbitMQ Bundle for the Symfony web framework
MIT License
1.22k stars 470 forks source link

Producer implementation does not respect its interface #672

Closed MollocH closed 2 years ago

MollocH commented 2 years ago

Hey there,

I am currently writing a new version for our https://github.com/auxmoney/OpentracingBundle-amqplib-RabbitMq which will support Version 2 of this bundle. While researching I found out that the producer implementation does not respect its interface.

This is the implementation: public function publish($msgBody, $routingKey = null, $additionalProperties = array(), array $headers = null) And this the interface public function publish($msgBody, $routingKey = '', $additionalProperties = array());

As far as I can see, there is already a PR for this issue since 2017. Do you need any help in merging it ?

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 10 days with no activity.