search

php-coder / mystamps

The site about post stamps where you can create a virtual collection
https://my-stamps.ru
GNU General Public License v2.0
20 stars 33 forks source link

MailServiceImpl: add unit tests #22

Open php-coder opened 10 years ago

php-coder commented 10 years ago

MailServiceImpl class doesn't have any unit tests. We should add them.

Technical Debt for: 681913b8b5228b6c8662206692277ae72726187f (#1)

php-coder commented 7 years ago

To simplify unit testing and to properly fix the following warnings from PMD:

[INFO] PMD Failure: ru.mystamps.web.service.MailServiceImpl:135 Rule:AccessorMethodGeneration Priority:3 Avoid autogenerated methods to access private fields and methods of inner / outer classes.
[INFO] PMD Failure: ru.mystamps.web.service.MailServiceImpl:141 Rule:AccessorMethodGeneration Priority:3 Avoid autogenerated methods to access private fields and methods of inner / outer classes.

I suggest to extract MimeMessagePreparator implementation to a separate class.

php-coder commented 5 years ago

I suggest to extract MimeMessagePreparator implementation to a separate class.

It has been extracted in cacc3cc47508a26c6cd7e36bb377722b2a65c61a (as part of #935)