search

php-coder / mystamps

The site about post stamps where you can create a virtual collection
https://my-stamps.ru
GNU General Public License v2.0
20 stars 33 forks source link

Get rid of usrz/bootstrap-languages dependency #246

Open php-coder opened 8 years ago

php-coder commented 8 years ago

Right now we're using usrz/bootstrap-languages from http://rawgit.com but we need to have it as a WebJar (especially as classic webjar, see https://github.com/webjars/webjars/issues/1185).

Tech debt for e5670188e22863d8f4d8b9c5e24e078cb3a5acdd (#216)

php-coder commented 7 years ago

Because of using external service, integration tests fail when they're running offline.

php-coder commented 7 years ago

Now I have a better idea -- don't use it at all :) We need only 2 tiny images with country flags and that's all. We can even embed these images in the page sources and don't load 2 external files (css/image).

php-coder commented 7 years ago

It turned out that loading of the https://cdn.rawgit.com/usrz/bootstrap-languages/3ac2a3d2b27ac43a471cd99e79d378a03b2c6b5f/languages.png leads to a redirect to https://raw.githubusercontent.com/usrz/bootstrap-languages/3ac2a3d2b27ac43a471cd99e79d378a03b2c6b5f/languages.png

php-coder commented 7 years ago

Don't forget to update CSP rules that were added in 4d0922ea3aec8be915271167871038f1d273ca6b

php-coder commented 5 years ago

rawgit.com is End Of Life and should be replaced.

php-coder commented 5 years ago

rawgit.com is End Of Life and should be replaced.

We can temporary move to jsdelivr: https://www.jsdelivr.com/rawgit

php-coder commented 5 years ago

We can temporary move to jsdelivr: https://www.jsdelivr.com/rawgit

Done in 4cfa56e19f5d49d9294d462b41aad79a738564b6 commit.

php-coder commented 4 years ago

Perhaps, we can take flags from https://www.gosquared.com/resources/flag-icons/