search

php-coder / mystamps

The site about post stamps where you can create a virtual collection
https://my-stamps.ru
GNU General Public License v2.0
20 stars 33 forks source link

/series/add: consider using details with summary as a replacement to links and divs #626

Open php-coder opened 7 years ago

php-coder commented 7 years ago

Idea from Pavel Finkelshtein (@asm0dey): instead of using JS code and chevrons for hiding parts of the form, it's better to use a pure CSS approach with <details>/<summary> tags: http://jsfiddle.net/thurstanh/emtAm/2/ It won't work in IE but it's OK because in this case all the parts will be visible.

php-coder commented 5 years ago

The old code is causing test flakes (like #556) because sometimes the block is visible and sometimes it's not. After fixing #565 the code for hiding/showing elements has started to use height(0) that seems causes flakes because zero height passes Wait Until Element Is Visible check.

php-coder commented 4 years ago

Could be related: https://habr.com/ru/post/477520/