search

php-ds / ext-ds

An extension providing efficient data structures for PHP 7
https://medium.com/p/9dda7af674cd
MIT License
2.11k stars 95 forks source link

Fix shared build on --enable-snaphot-build, change --with into --enable #127

Closed Jan-E closed 6 years ago

Jan-E commented 6 years ago

When PHP is built with --enable-snapshot-build with this repo cloned in ext/ds ds is compiled as static. This PR reverts the changes in the no/yes handling. See also https://github.com/php-ds/ext-ds/commit/844d7b1061bd78f51f3038c50143092e47f796d8#commitcomment-31395019

The PR also changes ARG_WITH into ARG_ENABLE. The convention is that --with is used for extensions with external libs and --enable for self-contained extensions

rtheunissen commented 6 years ago

Thank you so much for this. :sparkles:

Jan-E commented 6 years ago

BTW: I changed the test command into something that should run the standard *.phpt tests in ext/ds/tests. And discovered there were no such tests. I do not know if it is possible to translate the composer/phpunit tests that work on Travis into somethiing that works on Appveyor. Maybe @weltling knows it. Anyway, you never got this far on Appveyor, if I look back a little bit.

weltling commented 6 years ago

@Jan-E great you work on this. Sure you can run composer projects on AppVeyor. Composer might be available on Travis already, but you can download it, init the test project and run with the PHP just compiled. No difference to what one would do locally. Furthermore, use the build cache to store the downloaded composer, then you have control when you want to upgrade it.

Thanks.

rtheunissen commented 6 years ago

I'm working on a new major version where all tests are phpt instead, with no composer involved.

On Thu, Nov 22, 2018, 13:42 Anatol Belski <notifications@github.com wrote:

@Jan-E https://github.com/Jan-E great you work on it. Sure you can run composer projects on AppVeyor. Composer might be available on Travis already, but you can download it, init the test project and run with the PHP just compiled. No difference to what one would do locally. Furthermore, use the build cache to store the downloaded composer, then you have control when you want to upgrade it.

Thanks.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/php-ds/ext-ds/pull/127#issuecomment-441123952, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxY5w1Oif43ftDzj7HVojvQMC53glRkks5uxxpNgaJpZM4Yvcgm .