search

php-edifact / edifact-generator

Formatter for EDI messages
GNU Lesser General Public License v3.0
36 stars 29 forks source link

Traits PSR-4 violation / inconsistency #22

Closed buffcode closed 2 years ago

buffcode commented 2 years ago

The traits directory does not match the PSR-4 naming schema.

Furthermore, the traits use different namespaces:

The error can be detected by removing the autoload.classmap configuration from composer.json and running composer dump-autoload -a:

Class EDI\Generator\Traits\ContactPerson located in php-edifact/edifact-generator/src/Generator/traits/ContactPerson.php does not comply with psr-4 autoloading standard. Skipping.                                                                                                                
Class EDI\Generator\Traits\Item located in php-edifact/edifact-generator/src/Generator/traits/Item.php does not comply with psr-4 autoloading standard. Skipping.                                                                                                                                  
Class EDI\Generator\Traits\ItemPrice located in php-edifact/edifact-generator/src/Generator/traits/ItemPrice.php does not comply with psr-4 autoloading standard. Skipping.                                                                                                                        
Class EDI\Generator\Traits\NameAndAddress located in php-edifact/edifact-generator/src/Generator/traits/NameAndAddress.php does not comply with psr-4 autoloading standard. Skipping.                                                                                                              
Class EDI\Generator\Traits\TransportData located in php-edifact/edifact-generator/src/Generator/traits/TransportData.php does not comply with psr-4 autoloading standard. Skipping.
sabas commented 2 years ago

Thank you @buffcode ! 🎉