php-edifact / edifact-generator

Formatter for EDI messages
GNU Lesser General Public License v3.0
33 stars 28 forks source link

Fixed invalid constructors annotations, removed unused dynamic class property #27

Closed andreyserdjuk closed 1 year ago

sabas commented 1 year ago

Hello @andreyserdjuk and thank you! Are you using Iftmin? If I recall correctly I left it half-baked so perhaps it is missing part of segments... Are you planning to extend it?

andreyserdjuk commented 1 year ago

Hi, @sabas , at this moment I don't use Iftmin, - switched to extending Message.

andreyserdjuk commented 1 year ago

@sabas could you please merge it if everything is ok. Otherwise Interchange cannot be instantiated normally with custom $interchangeCode without ignore comments kinda @phpstan-ignore-next-line. Same issue with Message class.

sabas commented 1 year ago

Ok . Thanks!