php-edifact / edifact-generator

Formatter for EDI messages
GNU Lesser General Public License v3.0
36 stars 29 forks source link

Bugfix: declaration of compose must be compatible #5

Closed davidvandertuijn closed 5 years ago

davidvandertuijn commented 5 years ago

I updated the legacy Class structure to be compatible with the Message Class (__construct() and compose() function).

@sabas I try to keep the different Messages backworth compatible. In your current project, you MUST now set the Document Name Code parameter (2nd) when calling compose(), before they are set default in the constructor. It's RECOMMEND to use the new Segment Groups approach as introduced in the Cohaor Message. On the horizon all Message Classes should be simplified like to Cohaor Message Class, but that is up to you, because you must make changes in your current project.

sabas commented 5 years ago

Thank you, I will follow your suggestion as soon as possible!