php-edifact / edifact-generator

Formatter for EDI messages
GNU Lesser General Public License v3.0
33 stars 28 forks source link

Add support for orders & invoice #8

Closed viezel closed 5 years ago

viezel commented 5 years ago
viezel commented 5 years ago

@sabas ready for review

davidvandertuijn commented 5 years ago

Quick suggestions:

viezel commented 5 years ago

@davidvandertuijn sure ill change the reference. Regarding the mixed - well if you ask me it would rather go full strict type, but maybe to big of a refactor. So where do you want the change?

sabas commented 5 years ago

Thank you @viezel, I'll try to merge this night..

Just to ask also to @davidvandertuijn I pulled the changes in my client code some days ago and I noticed it failed with a type error when providing arrays with ints as it was annotated with string in the parameters, so I changed the default values from null to the previous value as string (15th march commit)

Do you want access to the repository or to the org?

viezel commented 5 years ago

Sure @sabas That would be neat to gain access. Then I could setup travis to automatically run tests for this

viezel commented 5 years ago

@sabas thanks for merging it in. can you grant me access to the repo, so I can tag the release so we follow semvar.

sabas commented 5 years ago

@viezel done please try