search

php-edifact / edifact

Tools to process EDI messages in UN/EDIFACT format
GNU Lesser General Public License v3.0
274 stars 87 forks source link

Extend error message for syntax errors #129

Closed szocsbarni closed 8 months ago

szocsbarni commented 8 months ago

The position and segmentID fields are added to the NOTCONFORMANT error message, in a similar manner as for the other error message types

sabas commented 8 months ago

Hi @szocsbarni why did you close the pr?

szocsbarni commented 8 months ago

hi @sabas, I created accidentally this partial PR, we are preparing one, with a few more changes, as you can see them here: https://github.com/php-edifact/edifact/compare/master...dextra-solutions:edifact:master

In general I would like to contribute to the repository, since we are using it actively. We truly appreciate the work being done here.

sabas commented 8 months ago

Thanks! In case you need it you can reach me out also by mail :)

szocsbarni commented 8 months ago

Thanks, is there a certain procedure/process that should be followed for PR creation?

sabas commented 8 months ago

Not really, feel free to do as you like....