[amqp-ext] Passing null to parameter is deprecated.

php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro

https://enqueue.forma-pro.com/

MIT License

2.17k stars 430 forks source link

Closed EmilMassey closed 6 months ago

EmilMassey commented 1 year ago

Fixes deprecation notice Deprecated: AMQPQueue::consume(): Passing null to parameter #3 ($consumer_tag) of type string is deprecated in

EmilMassey commented 1 year ago

I did not change the line reported by the code style check in this PR. I fixed that in a separate PR #1276

nightlinus commented 1 year ago

Nice change for 8.1 compatibility, can we have this merged please @makasim

makasim commented 1 year ago

Nice change for 8.1 compatibility, can we have this merged please @makasim

Indeed, once all tests are green

EmilMassey commented 1 year ago

Nice change for 8.1 compatibility, can we have this merged please @makasim

Indeed, once all tests are green

The failures seem to be unrelated to my changes (403 from AWS). Can you please take a look? Maybe they need to be rerun?

makasim commented 1 year ago

Sorry, I am not going to look into it. I don't use the library nor write in PHP.

I can review and merge when everything is green, and release it.