search

php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.17k stars 430 forks source link

Update doctrine/persistence #1290

Closed jlabedo closed 1 year ago

jlabedo commented 1 year ago

Update doctrine/persistence to ^3.0

makasim commented 1 year ago

I think it is too much to support three major versions at the same time.

Could you drop 1.x version ? It was updated about two years ago last time.

xNarkon commented 1 year ago

Any update on this? I can handle this topic if the original owner is out

makasim commented 1 year ago

I can handle this topic if the original owner is out

@xNarkon that would be great

xNarkon commented 1 year ago

@makasim https://github.com/php-enqueue/enqueue-dev/pull/1300

dgafka commented 1 year ago

Hey :)

@jlabedo can we drop the version 1 and push it forward?

jlabedo commented 1 year ago

Sorry for the delay @makasim, the branch is updated. I was super busy at work on a new project that uses enqueue and ecotone framework :)

jlabedo commented 1 year ago

@makasim , I think this PR could still be needed even after merging #1300 :

  1. It allows doctrine/persistence 3.0 and not only 3.1
  2. It make ci test against the latest ^3.0: as it is not updated in enqueue-dev root composer.json, the ci is still going on ^2.0 😄 (see: https://github.com/php-enqueue/enqueue-dev/actions/runs/4884813943/jobs/8857137748?pr=1300#step:7:39)