search

php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.17k stars 430 forks source link

Add explicit @return to solve Symfony deprecation #1295

Closed VincentLanglet closed 1 year ago

VincentLanglet commented 1 year ago

Hi @makasim,

This would close https://github.com/php-enqueue/enqueue-dev/issues/1261 according to the deprecation message.

VincentLanglet commented 1 year ago

Should i fix the code style (which is unrelated to my PR) @makasim ?

makasim commented 1 year ago

yes, please. otherwise, I cannot merge it.

VincentLanglet commented 1 year ago

@makasim Is it ok now ? :)

VincentLanglet commented 1 year ago

I rebased the PR on master, it should be better now @makasim

axcherednikov commented 1 year ago

Hi! When will you accept it?)

ruudk commented 1 year ago

@makasim Can this be merged please?